This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[v1.7.x] Backport #17885 #18128
Merged
[v1.7.x] Backport #17885 #18128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add debug prints to debug error in CI * add debug prints to debug error in CI * remove prints * initial commit * enabled calling create for selector * connected selector to call external class * added code to remove temp graph attrs * fixed build issues * changed shape inference to use different attr names * fixed selector class * cleaned up APIs * fixed sanity * updated build for extensions * sanity fix * refactored MXLoadLib into separate functions * undo rebase * finished merge * enabled verbose in library loading * fixed example * added passing args/aux down to graph pass * added creating new args/aux for graph passes * fixed return args/aux * fixed sanity * whitespace * fixed lint * updated perl API, README, added pass_lib to cmake build flow * fixed mistake with relu example lib * fixed perl syntax * addressed comments * addressed more comments * fixed compile issues Co-authored-by: Ubuntu <[email protected]> Co-authored-by: Ubuntu <[email protected]>
samskalicky
requested review from
aaronmarkham,
anirudh2290,
eric-haibin-lin,
sergeykolychev and
szha
as code owners
|
Hey @samskalicky , Thanks for submitting the PR
CI supported jobs: [centos-gpu, clang, sanity, edge, website, unix-gpu, centos-cpu, unix-cpu, miscellaneous, windows-gpu, windows-cpu] Note: |
Closed
|
Thanks @samskalicky , adding this PR to 1.7.0 roadmap #16864. |
|
Thanks @ciyongch! This PR is finally ready to merge. The same #18126 on the v1.x branch has already been merged. @PatricZhao @ptrendx |
|
@samskalicky thanks to help backport this feature to v1.7.x, ping @TaoLv @pengzhao-intel to help merge. |
TaoLv
approved these changes
Apr 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #17885